Implement bitarray pool in package search index. #8797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Jun 2, 2025
sigurdm
reviewed
Jun 2, 2025
sigurdm
reviewed
Jun 2, 2025
Comment on lines
+188
to
+192
| class BitArrayPool<K> { | ||
| final int _length; | ||
| final _pool = <BitArray>[]; | ||
|
|
||
| BitArrayPool(this._length); |
Contributor
There was a problem hiding this comment.
Doesn't matter too much, but I guess it could be generic, sharing implentation with ScorePool (if you pass a constructor).
Suggested change
| class BitArrayPool<K> { | |
| final int _length; | |
| final _pool = <BitArray>[]; | |
| BitArrayPool(this._length); | |
| class AllocationPool<T> { | |
| final _pool = <T>[]; | |
| final T Function() constructor; | |
| AllocationPool(this.constructor); |
Collaborator
Author
There was a problem hiding this comment.
I've checked but with the ScorePool's variable initialization parameter, it requires a bit of refactoring first. I'll do that in a follow-up PR.
sigurdm
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexedScore, but seems to be a bit more involved, postponing it for now (with a follow-up PR that may prepare it).